Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup BindingSourceHelper #4544

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cleanup BindingSourceHelper #4544

wants to merge 1 commit into from

Conversation

SimonCropp
Copy link
Contributor

  • move to file scoped namespace
  • use enumerable for GetChildBindingSources instead of assignable lists for each level in the hierarchy
  • use pattern matching in GetChildBindingSources

@rockfordlhotka
Copy link
Member

@SimonCropp there aren't really unit tests for the Windows UI components. Can you confirm that this change doesn't break existing functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @rockfordlhotka